Skip to content

fix: updating ucxx, which appears to avoid occasional segfaults when profiling #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025

Conversation

hypdeb
Copy link
Collaborator

@hypdeb hypdeb commented Apr 9, 2025

I observed some segfaults and other strange behaviour when running nsys profile on the application recently. The stack was referring to this dependency. I tried updating it, it appears to have solved the issue.

@hypdeb hypdeb added the bug Something isn't working label Apr 9, 2025
@hypdeb hypdeb requested review from litaotju and Shixiaowei02 April 9, 2025 13:19
@hypdeb hypdeb self-assigned this Apr 9, 2025
@hypdeb
Copy link
Collaborator Author

hypdeb commented Apr 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1619 [ run ] triggered by Bot

@Shixiaowei02 Shixiaowei02 requested a review from chuangz0 April 9, 2025 14:17
@chuangz0
Copy link
Collaborator

chuangz0 commented Apr 9, 2025

what error you encounter?
which verison ucxx update to?

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1619 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #1212 completed with status: 'SUCCESS'

@hypdeb
Copy link
Collaborator Author

hypdeb commented Apr 9, 2025

@chuangz0, waiting for your review to merge.

@hypdeb hypdeb enabled auto-merge (squash) April 10, 2025 06:31
@hypdeb
Copy link
Collaborator Author

hypdeb commented Apr 10, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1769 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1769 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #1619 for commit e4c1289

@hypdeb hypdeb merged commit d7a0bf9 into NVIDIA:main Apr 10, 2025
2 checks passed
Superjomn pushed a commit to Superjomn/TensorRT-LLM that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants