Skip to content

fix: Correct reporting of text dtype for Llama 4. #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: Correct reporting of text dtype for Llama 4. #3494

merged 1 commit into from
Apr 17, 2025

Conversation

FrankD412
Copy link
Collaborator

This is a quick fix that corrects a configuration file format change for Llama 4.

NOTE: This fix is only meant to be an unblocking fix. I will submit a PR in the future to correct this reporting.

@FrankD412 FrankD412 requested a review from kaiyux April 12, 2025 06:46
@FrankD412 FrankD412 self-assigned this Apr 12, 2025
@FrankD412
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1999 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #1999 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #1475 completed with status: 'FAILURE'

@FrankD412
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2110 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2110 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #1539 completed with status: 'FAILURE'

@FrankD412
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2202 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2202 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #1591 completed with status: 'SUCCESS'

kaiyux
kaiyux approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@kaiyux kaiyux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@FrankD412 @kaiyux
Quick fix to reporting.
3cde3f0 
Signed-off-by: Frank Di Natale <[email protected]>
@kaiyux kaiyux force-pushed the trtllm-bench/quick_fix_config branch from 7997ab4 to 3cde3f0 Compare April 17, 2025 15:56
@kaiyux
Copy link
Member

kaiyux commented Apr 17, 2025

/bot reuse-pipeline

@kaiyux kaiyux enabled auto-merge (squash) April 17, 2025 15:57
@tensorrt-cicd
Copy link
Collaborator

PR_Github #2657 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2657 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #2202 for commit 3cde3f0

@kaiyux kaiyux merged commit 5a6cb2b into NVIDIA:main Apr 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyux kaiyux kaiyux approved these changes

Assignees

@FrankD412 FrankD412

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankD412 @tensorrt-cicd @kaiyux