-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Clean up modeling_deepseek.py #3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/bot run --disable-fail-fast |
PR_Github #2533 [ run ] triggered by Bot |
PR_Github #2533 [ run ] completed with state |
/bot run --disable-fail-fast |
PR_Github #2596 [ run ] triggered by Bot |
/bot kill |
PR_Github #2601 [ kill ] triggered by Bot |
PR_Github #2596 [ run ] completed with state |
PR_Github #2601 [ kill ] completed with state |
/bot run --disable-fail-fast |
PR_Github #2605 [ run ] triggered by Bot |
PR_Github #2605 [ run ] completed with state |
/bot run --disable-fail-fast |
PR_Github #2672 [ run ] triggered by Bot |
PR_Github #2672 [ run ] completed with state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Hao Lu <[email protected]>
The
modeling_deepseek.py
files looks mostly clean after this round of cleaning. I kept the allreduce part the same because we need the allreduce op unification PR to land first.For accuracy test, I ran the
examples/pytorch/quickstart_advanced.py
script with the R1 model with different configs.