Skip to content

fix: fnmatch usage in modeling_utils.py (https://nvbugspro.nvidia.com/bug/5234567) #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix: fnmatch usage in modeling_utils.py (https://nvbugspro.nvidia.com/bug/5234567) #3754

merged 1 commit into from
Apr 22, 2025

Conversation

syuoni
Copy link
Collaborator

@syuoni syuoni commented Apr 22, 2025

No description provided.

@syuoni
fix
07717fa 
Signed-off-by: Enwei Zhu <[email protected]>
@syuoni syuoni requested a review from kaiyux April 22, 2025 04:14
@syuoni
Copy link
Collaborator Author

syuoni commented Apr 22, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3015 [ run ] triggered by Bot

@syuoni
Copy link
Collaborator Author

syuoni commented Apr 22, 2025

The test case accuracy/test_cli_flow.py::TestLlama3_1_8B::test_autoq is on post-merge. It passed locally with this fix

...
Average accuracy 67.71 (576) - health
Average accuracy 53.32 (1296) - STEM
Average accuracy 69.87 (936) - humanities
Average accuracy 74.77 (864) - social sciences
Average accuracy 67.36 (1008) - other (business, health, misc.)
MMLU weighted average accuracy: 65.06 (4104)

QiJune
QiJune approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyux kaiyux enabled auto-merge (squash) April 22, 2025 04:50
@kaiyux
Copy link
Member

kaiyux commented Apr 22, 2025

/bot skip --comment "safe to skip"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3024 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3015 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3024 [ skip ] completed with state SUCCESS
Skipping testing for commit 07717fa

@kaiyux kaiyux merged commit 353699a into NVIDIA:main Apr 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

@kaiyux kaiyux Awaiting requested review from kaiyux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syuoni @tensorrt-cicd @kaiyux @QiJune