Skip to content

Revert "Fix crash computing zero(ZZ[t]) - zero(ZZ) (#1930)" #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2025

Conversation

lgoettgens
Copy link
Member

This reverts commit ce4c582.

To be merged once flintlib/flint#2102 is available. (probably with FLINT 3.2.0)

@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Jan 29, 2025
@lgoettgens lgoettgens requested a review from fingolfin March 19, 2025 14:12
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (a77eb6c) to head (bdca762).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
- Coverage   88.05%   88.04%   -0.02%     
==========================================
  Files         100      100              
  Lines       36903    36901       -2     
==========================================
- Hits        32494    32488       -6     
- Misses       4409     4413       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens requested a review from thofma March 19, 2025 14:54
@lgoettgens
Copy link
Member Author

This removes a workaround for an issue that is fixed in FLINT 3.2.0.

@lgoettgens
Copy link
Member Author

Bump

@thofma thofma merged commit 169fa54 into master Apr 19, 2025
25 of 26 checks passed
@thofma thofma deleted the revert-1930-mh/fmpz_poly_sub_fmpz-crash-fix branch April 19, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants