feat(project): Defer creation of the component instance #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…visible in the viewport
easingthemes
requested changes
Apr 3, 2025
| }, observerSettings); | ||
|
|
||
| observer.observe(element); | ||
| } else { |
There was a problem hiding this comment.
Minor: Maybe better to use early return instead of if/else, to follow same pattern as at the beginning of the function.
| @@ -17,7 +17,7 @@ export const run = (element = window.document, initAttr = 'data-nc') => | |||
| // get the component that needs, will load by attribute | |||
There was a problem hiding this comment.
Minor: Not sure if it's better to have observer here, when we have the node, instead in a factory.
Since in factory observer is called (created and destroyed) for each Component (data-nc="Com1, Com2, Com3"), while we need it only for element, regardless of Components.
This is not used that much, but still it's an option.
|
Please run tests and update Checklist: in the description. |
easingthemes
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an option to defer component instantiation until it becomes visible in the viewport.
Description
Related Issue
Fixes #9
Types of changes
Checklist: