Skip to content

Add auto-generated pyi files to Metaflow #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
0e65315
Fix some docstrings and add Add To Current
romain-intel Sep 28, 2023
9bda196
Docstring changes
romain-intel Oct 2, 2023
cfc12a6
More docstrings
romain-intel Oct 11, 2023
d7f17ca
Stub generator script
romain-intel Oct 17, 2023
fae3825
More docstring fixes
romain-intel Oct 19, 2023
3c589ad
Improve stub generator script
romain-intel Oct 19, 2023
d543639
Add specialized function in the client to get proper return types
romain-intel Oct 20, 2023
c743b9f
Fix invalid docstrings
romain-intel Oct 20, 2023
43e07e7
Fixup more stuff in stub generator
romain-intel Oct 24, 2023
cd1bb4e
make docstrings consistent
tuulos Dec 15, 2023
211d6e2
Small fixes
romain-intel Jan 4, 2024
7aae809
Move current.py to metaflow_current.py
romain-intel Jan 5, 2024
469d02a
Minor tweaks
romain-intel Jan 9, 2024
f67d4d9
Added MANIFEST.in
romain-intel Jan 10, 2024
772fcda
Fix issues with numpydoc compilation
romain-intel Jan 12, 2024
7b279fa
Updated stub generator to include step and type check decorators better
romain-intel Jan 14, 2024
98140e5
Addressed comments
romain-intel Jan 23, 2024
e485644
Added a stub command; moved script to new location. (#1682)
romain-intel Jan 23, 2024
6ebcd3c
Merge remote-tracking branch 'origin/master' into feat/autodocs
romain-intel Jan 23, 2024
19a30b0
Small fixes to be better with PyCharm
romain-intel Jan 24, 2024
eda6382
Example test with more flexible verification for mypy
romain-intel Jan 24, 2024
0da1858
use regex for mypy tests (#1697)
madhur-ob Jan 25, 2024
a40e971
edit testing CI (#1699)
madhur-ob Jan 25, 2024
e9ddfc9
separate workflow for testing stubs (#1701)
madhur-ob Jan 25, 2024
94a936e
fix test stubs workflow (#1702)
madhur-ob Jan 25, 2024
a694136
add timeout (#1703)
madhur-ob Jan 25, 2024
1945812
remove on_retry_command
madhur-ob Jan 25, 2024
d21c8ce
Fix issue with stub generator for TypeVar
romain-intel Jan 26, 2024
54766e9
Add extra requires to main setup.py
romain-intel Jan 26, 2024
a00c663
publish stubs package before (#1705)
madhur-ob Jan 29, 2024
f8e05cd
Change color of 'valid'
romain-intel Jan 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metaflow/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class and related decorators.
from .metaflow_profile import profile

# current runtime singleton
from .current import current
from .metaflow_current import current

# Flow spec
from .flowspec import FlowSpec
Expand Down
5 changes: 1 addition & 4 deletions metaflow/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from . import decorators
from . import metaflow_version
from . import namespace
from . import current
from .metaflow_current import current
from .cli_args import cli_args
from .tagging_util import validate_tags
from .util import (
Expand Down Expand Up @@ -235,7 +235,6 @@ def output_dot(obj):
)
@click.pass_obj
def dump(obj, input_path, private=None, max_value_size=None, include=None, file=None):

output = {}
kwargs = {
"show_private": private,
Expand Down Expand Up @@ -738,7 +737,6 @@ def resume(
decospecs=None,
run_id_file=None,
):

before_run(obj, tags, decospecs + obj.environment.decospecs())

if origin_run_id is None:
Expand Down Expand Up @@ -824,7 +822,6 @@ def run(
user_namespace=None,
**kwargs
):

if user_namespace is not None:
namespace(user_namespace or None)
before_run(obj, tags, decospecs + obj.environment.decospecs())
Expand Down
Loading