Skip to content

fix(vispy): handle case where no rotation is required #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix(vispy): handle case where no rotation is required #451

wants to merge 1 commit into from

Conversation

sanjayankur31
Copy link
Member

Otherwise scipy errors with:

  File ".../pyneuroml/plot/PlotMorphologyVispy.py", line 1714, in create_mesh
    rot_obj = Rotation.from_matrix(rot_matrix)
  File "_rotation.pyx", line 1136, in scipy.spatial.transform._rotation.Rotation.from_matrix
ValueError: Non-positive determinant (left-handed or null coordinate frame) in rotation matrix 0: [[0. 0. 0.]
 [0. 0. 0.]
 [0. 0. 0.]].

@sanjayankur31
fix(vispy): handle case where no rotation is required
63181e9 
Otherwise scipy errors with:

```
  File ".../pyneuroml/plot/PlotMorphologyVispy.py", line 1714, in create_mesh
    rot_obj = Rotation.from_matrix(rot_matrix)
  File "_rotation.pyx", line 1136, in scipy.spatial.transform._rotation.Rotation.from_matrix
ValueError: Non-positive determinant (left-handed or null coordinate frame) in rotation matrix 0: [[0. 0. 0.]
 [0. 0. 0.]
 [0. 0. 0.]].

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sanjayankur31