Skip to content

Remove line in pp #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Remove line in pp #201

merged 2 commits into from
Jun 16, 2025

Conversation

Thomasb81
Copy link
Contributor

Partial PR of change done in #191

Remove new line added by preprocessor. as discuss in #166 (comment)

Note: New test test_from_subdirectory2 is a copy of existing test_from_subdirectory with subtle difference in included files:

$xxd tests/sv_pp/src/include_many_dir/dir0-a/dir1-a/file2-a.txt 
00000000: 2266 696c 6532 2d61 2e74 7874 22         "file2-a.txt"
xxd tests/sv_pp/src/include_many_dir/dir0-a/dir1-a/file2-b.txt 
00000000: 2266 696c 6532 2d61 2e74 7874 220a       "file2-a.txt".

(Ending character of file2-b.txt is LF, not easily visible in text diff)

May be the tool should test if included file end by LF to add or not the removed new-line, but adding a character not present in source code, seems not to be a good idea...

@Nic30 Nic30 merged commit c5b80a1 into Nic30:master Jun 16, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants