Rework derivation input resolution #12567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
slightly-rework-drv-resolution
branch
2 times, most recently
from
7c72198 to
071b73f
Compare
I refactored the way that input resolution works in `DerivationGoal`. To be honest, it is probably unclear to the reader whether this new way is better or worse. I suppose *intrinsic* motivation, I can say that - the more structured use of `inputGoal` (a local variable) is better than the shotgrun approach with `inputDrvOutputs` - A virtual `waiteeDone` was a hack, and now it's gone. However, the *real* motivation of this is not the above things, but that it is needed for my mammoth refactor fixing NixOS#11897 and NixOS#11928. It is nice that this step could come first, rather than making that refactor even bigger.
Ericson2314
force-pushed
the
slightly-rework-drv-resolution
branch
from
071b73f to
a58e058
Compare
Mic92
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I refactored the way that input resolution works in
DerivationGoal. To be honest, it is probably unclear to the reader whether this new way is better or worse. I suppose intrinsic motivation, I can say thatthe more structured use of
inputGoal(a local variable) is better than the shotgrun approach withinputDrvOutputsA virtual
waiteeDonewas a hack, and now it's gone.Context
However, the real motivation of this is not the above things, but that it is needed for my mammoth refactors fixing #11897 and #11928, and now also removing
addWantedOutputsso dyn drvs can land safely.It is nice that this step could come first, rather than making that refactor even bigger.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.