-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Store StructuredAttrs
directly in Derivation
#13263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6440a9f
to
e8800da
Compare
Thanks to talking to @puckipedia, I became satisfied that the other way of changing the abstract syntax (pair of env and optional structured attrs) wasn't "too lax" because there already was a way within the language to mix arbitrary env vars with structured attrs. This PR is now updated to work that way, and is passing all the tests, but let's look at #13273 first. |
62c3124
to
2aa355f
Compare
Instead of parsing a structured attrs at some later point, we parsed it right away when parsing the A-Term format, and likewise serialize it to `__json = <JSON dump>` when serializing a derivation to A-Term. The JSON format can directly contain the JSON structured attrs without so encoding it, so we just do that.
2aa355f
to
d7e3265
Compare
🎉 All dependencies have been resolved ! |
Notes from today's Nix team meeting:
|
Needs discussion to address potential perf and laziness implications. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2025-05-28-nix-team-meeting-minutes-229/65205/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2025-05-04-nix-team-meeting-minutes-230/65206/1 |
Instead of parsing a structured attrs at some later point, we parsed it right away when parsing the A-Term format, and likewise serialize it to
__json = <JSON dump>
when serializing a derivation to A-Term.The JSON format can directly contain the JSON structured attrs without so encoding it, so we just do that.
Motivation
Depends on #13273
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.