Skip to content

Fix #13293 #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Fix #13293 #13294

merged 2 commits into from
Jun 11, 2025

Conversation

Ericson2314
Copy link
Member

Motivation

Fix #13293

Context

We move the assertPathValidity to where we know what the wanted outputs are.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@xokdvium

This comment was marked as resolved.

It currently fails, before the fix.
@Ericson2314 Ericson2314 requested a review from edolstra as a code owner June 11, 2025 20:13
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jun 11, 2025
We move the `assertPathValidity` to where we know what the wanted
outputs are.
@Ericson2314

This comment was marked as resolved.

Copy link
Contributor

@xokdvium xokdvium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case fails without the second commit and passes with the second one. Seems good to me. Not sure about all of the implementation details though.

@Ericson2314 Ericson2314 enabled auto-merge June 11, 2025 20:26
@Ericson2314 Ericson2314 merged commit 371fcf9 into NixOS:master Jun 11, 2025
12 checks passed
@Ericson2314 Ericson2314 deleted the fix-13293 branch June 13, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking broken with only some outputs
2 participants