Skip to content

flameshot: fix under KDE wayland #145777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Nov 13, 2021

Motivation for this change

KWin relies on absolute path in Exec= to find a process's corresponding desktop file and check if it's allowed to take screenshot. So we need to set Exec= to the absolute path instead of just flameshot.

KWin detail is discussed in flameshot-org/flameshot#1380

For testers: you may need to install it to environment.systemPackages and re-login to make it work.

cc: @jansol @haizaar

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This is required since KWin relies on absolute paths in `Exec=` to find a process'
corresponding desktop file and check if it's allowed to take screenshot.
@ofborg ofborg bot requested a review from scode November 13, 2021 17:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 13, 2021
@jansol
Copy link
Contributor

jansol commented Nov 13, 2021

Screenshot shortcut now works. It still takes a couple of seconds to actually respond to the key press but at least cropping is pretty much instant, unlike with Spectacle. Having two monitors seems to confuse flameshot greatly but that seems to be a known upstream issue. (flameshot-org/flameshot#1386)

@github-actions
Copy link
Contributor

Successfully created backport PR #151074 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants