Skip to content

Fix some JUCE packages on Darwin #230730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2023
Merged

Fix some JUCE packages on Darwin #230730

merged 3 commits into from
May 23, 2023

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented May 8, 2023 •
edited
Loading

Description of changes
  • fire and dexed started missing Accelerate framework
  • bespokesynth (and bespokesynth-with-vst2) started missing IOBluetooth framework, and Accelerate on aarch64

Test-built locally on my x86_64-darwin system. Checked that dexed and bespokesynth launch, VST3 version of fire loaded within bespokesynth.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 8, 2023
@ofborg ofborg bot requested review from astro and tobiasBora May 8, 2023 17:51
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 8, 2023
tobiasBora
tobiasBora approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@tobiasBora tobiasBora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any darwin to test, but there is little risk to break anything with a simple additional dependency. Good for me.

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 9, 2023
@OPNA2608 OPNA2608 force-pushed the fix/JUCE-pkgs-darwin branch from fdd1855 to 5b90562 Compare May 11, 2023 12:07
@OPNA2608
Copy link
Contributor Author

aarch64-darwin CI said bespokesynth also needs Accelerate, so added that:

/tmp/nix-build-bespokesynth-1.1.0.drv-0/source/libs/JUCE/modules/juce_audio_basics/juce_audio_basics.cpp:47:11: fatal error: 'Accelerate/Accelerate.h' file not found

@ofborg ofborg bot requested a review from tobiasBora May 11, 2023 12:55
@mweinelt mweinelt removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 11, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2246

@figsoda figsoda mentioned this pull request May 23, 2023
Closed
12 tasks
@figsoda figsoda merged commit dbb3ffd into NixOS:master May 23, 2023
@github-actions github-actions bot mentioned this pull request May 23, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

@astro astro Awaiting requested review from astro

@tobiasBora tobiasBora Awaiting requested review from tobiasBora

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OPNA2608 @nixos-discourse @tobiasBora @figsoda @mweinelt