keyd: 2.4.2 -> 2.4.3

[JohnAZoidberg]

Description of changes

https://github.com/rvaiya/keyd/releases/tag/v2.4.3

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[JohnAZoidberg]

Works fine when running from the commandline but seems to break the keyd service. I'm investigating.

[peterhoeg]

off-topic, but I’m using `evscript' which works great for my simple needs.

[JohnAZoidberg]

Works now. The program calls nice which was blocked by systemd.
cc module author @woojiq

[woojiq]

@JohnAZoidberg haven't tested it manually, but if it passes the qemu test it's probably fine. Have you read this comment:

nixpkgs/nixos/modules/services/hardware/keyd.nix

Lines 115 to 119 in 3e01b04

	# this is configurable in 2.4.2, later versions seem to remove this option.
	# post-2.4.2 may need to set makeFlags in the derivation:
	#
	# makeFlags = [ "SOCKET_PATH/run/keyd/keyd.socket" ];
	environment.KEYD_SOCKET = "/run/keyd/keyd.sock";

See: #221321 (comment)
It's not mine, so does the new release affect it somehow?

[JohnAZoidberg]

It's not mine, so does the new release affect it somehow?

Hmmm, if we change it at compile time it won't run from commandline anymore. Only in the service.
Since the keyd folder doesn't exit. I guess it's okay actually, since you'd not usually run it manually.

[woojiq]

I've tested manually too and it seems useless now. Though you are probably more experienced with nix so make final decision, xd.

- # this is configurable in 2.4.2, later versions seem to remove this option.
- # post-2.4.2 may need to set makeFlags in the derivation:
- #
- #     makeFlags = [ "SOCKET_PATH/run/keyd/keyd.socket" ];
- environment.KEYD_SOCKET = "/run/keyd/keyd.sock";
-

Everything else is LGTM

[maxammann]

Looks good to me. Can we merge this?

keyd on 2.4.2 has a bug where it takes up 100% of the CPU. I believe this is fixed in the newer version.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1291

[pbsds]

Result of nixpkgs-review pr 245327 run on x86_64-linux 1

2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

1 package built:

• keyd

nixosTests.keyd also passes. LGTM

[github-actions]

Successfully created backport PR for release-23.11:

• [Backport release-23.11] keyd: 2.4.2 -> 2.4.3 #285246