nixos/livekit: init, nixos/lk-jwt-service: init

[Henry-Hiles]

Things done

Added a module for lk-jwt-service, and livekit, needed for running element-call (already packaged). For a usage example, see here: https://git.henryhiles.com/Henry-Hiles/nixos/src/branch/main/clients/quadraticserver/element-call.nix

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[mweinelt]

I did a first pass to grasp the structure of this and I have some questions on how to best represent the configuration.

Some of the changes apply to both modules, but I only commented on them once.

[mweinelt]

Second pass.

Looks like you created broken references when refactoring the module. Are you using a language server? I will recommend nil just in case.

I'm now pretty confident about the livekit configuration: We pass in both the configuration and a dedicated keys file.

[Henry-Hiles]

Second pass.

Looks like you created broken references when refactoring the module. Are you using a language server? I will recommend nil just in case.

I'm now pretty confident about the livekit configuration: We pass in both the configuration and a dedicated keys file.

I am using nil, but it doesn't appear to work that well...

[mweinelt]

Third pass, a bit smaller because we're slowly getting there.

What I would like next, as previously announced, is a NixOS test. I'm not sure about the scope, whether one for LiveKit itself makes sense or one for the Element Call stack would be more appropriate.

Now we most likely won't place calls on that test, but it should demonstrate the integration of these options with each other and provide some guarantees, that it keeps working.

[Henry-Hiles]

Third pass, a bit smaller because we're slowly getting there.

What I would like next, as previously announced, is a NixOS test. I'm not sure about the scope, whether one for LiveKit itself makes sense or one for the Element Call stack would be more appropriate.

Now we most likely won't place calls on that test, but it should demonstrate the integration of these options with each other and provide some guarantees, that it keeps working.

Hi, I'd prefer not to bother writing a test, as I have no idea how to do so. Could either you write one or this could be merged and a test could be added later? Thanks.

[Henry-Hiles]

Huh, despite running treefmt, newlines were removed in all-tests.nix

[mweinelt]

Please don't reformat all-tests.nix and restore the removed blank lines in the packages.

[Henry-Hiles]

Please don't reformat all-tests.nix and restore the removed blank lines in the packages.

I will. Do you think these tests are enough, though?

[mweinelt]

They're a start. Ideally we could show some crucial interaction between these services (or between lk-jwt-service and element-call) works.

[Henry-Hiles]

They're a start. Ideally we could show some crucial interaction between these services (or between lk-jwt-service and element-call) works.

Right. Is that needed for this PR? I really have no idea how the internals work so this will require a deep dive into livekit documentation / internals for me.

[Henry-Hiles]

Okay, I think formatting should be good now.

[Henry-Hiles]

Why did that check fail?

[LordGrimmauld]

Github is rate-limiting its own CI, this happens sometimes. This particular fail shouldn't be an issue.

[Henry-Hiles]

Ah, seems to have worked now, thanks.

[mweinelt]

Thank you!