-
Notifications
You must be signed in to change notification settings - Fork 19
feat(tarball): implement new EntryFilesAnalyser API #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 72834db The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b593c44
to
b516bf9
Compare
b516bf9
to
070176f
Compare
c90cb77
to
00fabfc
Compare
5d63331
to
2112de1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the new EntryFilesAnalyser API and refactors the tarball scanning workflow. Key changes include:
- Integration of the EntryFilesAnalyser API in the SourceCodeScanner class.
- Introduction of a new NpmTarball class and modifications in tarball extraction and scanning.
- Updates across test files and documentation to support these API changes.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
workspaces/tarball/test/fixtures/scanPackage/entryfiles/src/index.js | Uses CommonJS require with an imported ESM module, which may cause module system inconsistency. |
workspaces/tarball/test/fixtures/scanPackage/entryfiles/src/foo.js | Exports using ES module syntax while being required from a CommonJS module. |
workspaces/tarball/test/SourceCodeScanner.spec.ts | Contains a minor spelling issue in a test description. |
workspaces/tarball/src/tarball.ts | Refactored to use the new NpmTarball class and updated dependency extraction. |
workspaces/tarball/src/class/SourceCodeScanner.class.ts | Updated to leverage the new EntryFilesAnalyser API for processing manifest entry files. |
workspaces/tarball/src/class/NpmTarball.class.ts | New file implementing tarball scanning logic in line with the updated API. |
workspaces/scanner/src/depWalker.ts | Adjusted to use the TempDirectory class and updated scanDirOrArchiveEx call. |
01802eb
to
72834db
Compare
72834db
to
a0d16ef
Compare
No description provided.