Skip to content

Add options for CMIP6 settings through usermods #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-1.6
Choose a base branch
from

Conversation

TomasTorsvik
Copy link
Contributor

This PR makes it possible to enable CMIP6 settings for BLOM/iHAMOCC through usermods.

I start including this on the release-1.6 branch, since this is what is being tested currently for NorESM2.3. If this is accepted, I will enable these usermods, with necessary modifications, for the v1.7 and master branches as well.

Copy link
Contributor

@matsbn matsbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this looks fine!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in NorESM Development May 13, 2025
@jmaerz
Copy link
Collaborator

jmaerz commented May 14, 2025

@matsbn and @TomasTorsvik , I wonder, if there is any good reason to put this into usermods - and not into the namelist_definition_blom.xml? - since to my understanding the isopycnic bulkmixlayer setup isn't been further developed, they are currently mostly run in CMIP6-compatible mode anyway, right?

@mvertens
Copy link
Contributor

@TomasTorsvik - I agree with @jmaerz. Here is an alternative proposal:

  • A new BLOM xml variable can be defined in config_component.xml - say BLOM_CMIP6
  • A new variable can be defined in buildnml - say cmip6_setting
    cmip6_setting = case.get_value("BLOM_CMIP6")
  • then namelist_definition_blom.xml can use this as follows:
  <entry id="edanis">
    <type>logical</type>
    <category>diffusion</category>
    <group>diffusion</group>
    <values>
      <value>.true.</value>
      <value "cmip6_setting">.false.</value>
    </values>
    <desc>If true, apply anisotropy correction to eddy diffusivity (l)</desc>
  </entry>

The above can modified to also have grid dependent settings.

@jmaerz
Copy link
Collaborator

jmaerz commented May 14, 2025

@mvertens , thanks, yes, that would be the other alternative, which could also make sense, if the isopycnic wil be further developed/used differently than with CMIP6 settings.

@mvertens
Copy link
Contributor

I think that an advantage with this approach is the there is only one xml variable that needs to be set - rather than multiple user_mod directories - potentially for different grids.

@TomasTorsvik
Copy link
Contributor Author

@jmaerz , @mvertens , @matsbn
I can try to implement the namelist_definition_blom.xml, perhaps in a new PR as it is different from the approach in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants