-
Notifications
You must be signed in to change notification settings - Fork 26
Support for initial conditions from WOA in situ temperature and practical salinity climatology, offline horizontally regridded to model grid #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…actical salinity climatology as initial condition. The climatology must horizontally regridded to model grid offline.
@matsbn - Thanks for the PR! As I understand it, this PR should go before #573 , as it provides the library for reading in WOA18 standard variables that will be converted to model internal variables. Is that correct? I'm a bit uncertain if you really mean to merge the two PRs, as the current approach seems to be a two-step implementation (I think a two-step approach is cleaner). I was looking for a tag for the TEOS-10/GSW-Fortran library, but I see that the last tag is from 2017 and last update on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think given that there will be two ways to do the input - nuopc and what is implemented here - the vertical remapping should be split up into its own file - so that it an be leveraged by #573. Then there will be the read you have here and the read that is in #573. It would be helpful to have the modularity in place that could clarify what needs to be done in the nuopc interface to leverage the vertical remapping.
@matsbn @TomasTorsvik - is the plan to have #573 in place for the June freeze? |
It could be that the right order is to merge this before #573 as a first step of a two-step process, but I am open to discuss this, particularly with @mvertens. I anyway want the ability to read in WOA data that are offline regridded to be able to do efficient development in standalone BLOM configurations. I was not so happy with the tagging in the TEOS-10/GSW-Fortran library, as there are bugfixes in master which are not in any tags. Although not ideal, I think the master branch is the right one to use for now. Maybe there are som "fx*" lines missing in .gitmodules for git-fleximod? |
I guess there are many ways to do this. I felt it was most natural to keep the vertical regridding out of the NUOPC interface. The
and also a public logical variable Probably another chat would be useful on this topic, @mvertens. |
@matsbn - definitely another chat would be useful. I was not suggesting that we should move the vertical regridding into the nuopc interface - only that it appear in a modular way not tied in to reading the offline regridding. This is a design issue that will keep coming up as online regridding is added for initial data. I just ran into this issue yesterday in terms of getting the riverin input working. I'm happy to talk this afternoon or tomorrow other than at 2-3. |
@matsbn - Yes, I meant to say that we should not use the tag version of the TEOS-10/GSW-Fortran library, as this is clearly outdated. I don't think we need "fx*" lines to pull the latest version of the |
@matsbn - simply creating another subroutine in mod_inicon.F90 that reads in the offline data but does not do any vertial interpolation would address what I am suggesting. Other than that I agree with you that the noupc
This same type of logic can equally be used for the riverin input. |
@mvertens for the riverine input, isn't it probably best to follow closely what you have done for the dust-stream? The difference being that there is the special re-mapping files that are not necessary for the dust. |
@JorgSchwinger - that is exactly what I am sugggesting. I have a new module in driver/nuopc - |
@@ -10,3 +10,6 @@ | |||
fxtag = v1.1.1 | |||
fxrequired = AlwaysRequired | |||
fxDONOTUSEurl = https://github.com/jmaerz/M4AGO-sinking-scheme | |||
[submodule "pkgs/GSW-Fortran"] | |||
path = pkgs/GSW-Fortran | |||
url = https://github.com/TEOS-10/GSW-Fortran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entirely sure, but I would expect that git fleximod also supports the sha number of e.g. the master so that the behavior of the TEOS can at least be expected to be fixed. Maybe worth giving it a try.
PR updated based on discussion with @mvertens:
|
@matsbn - I am trying to run the latest code here with the nuopc cap - but keeping woa_nuopc_provided=.false.
So what values should I use for sigref? How do I get the current code to run with woa_nuopc_provided=.false. ? |
@mvertens, sorry that I did not inform about this earlier. Required namelist settings for
|
With this PR, BLOM can start integration from initial conditions from WOA climatology of in situ temperature and practical salinity. The WOA climatology must be offline horizontally regridded to model grid, and only ALE vertical coordinates are supported for now. Eventually, this should be merged with the functionality in #573 for online regridding of the WOA climatology in the NUOPC framework.
The application of previous initial conditions are still supported. The variables in the file specified by the namelist variable
icfile
are inspected to detect the type of initial conditions. Currently, climatologies have been regridded for the tnx1v4 and tnx2v1 grids and are available on Betzy here:For the conversion from in situ temperature to potential temperature, the Gibbs SeaWater (GSW) Oceanographic Toolbox of TEOS-10 has been incorporated as a git submodule.