[Task] Create and Deploy Serverless Artillery test for /Users/{UserID}/Tasks/{TaskID} #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 2, 2021 18:26
kieranmiguel
approved these changes
Feb 5, 2021
toddysm
reviewed
Feb 6, 2021
| @@ -0,0 +1 @@ | |||
| version: 0.0.1 | |||
There was a problem hiding this comment.
Do we need all other files in addition to the YAML?
chonger878
reviewed
Feb 6, 2021
| }, | ||
|
|
||
| /** | ||
| * Analyze a set of sampling reports, each of which is the result of a sample battery's execution |
There was a problem hiding this comment.
I appreciate you adding documentation for the parameters and what each function does. It really helps me figure out the logic of each line of code here! :)
chonger878
reviewed
Feb 6, 2021
| @@ -0,0 +1,17 @@ | |||
| const sampling = require('./sampling.js') | |||
There was a problem hiding this comment.
Maybe it's just me, but perhaps I could recommend that you can make a quick comment or something that summarizes what artillery-acceptance, artillery-performance, and artillery monitoring does? I mean, I guess the titles are descriptive enough....maybe I am just being nitpicky.
chonger878
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is it
This pull request completes the performance test and sets up the test folder with the dependencies needed for slsart to run and deploy resources for slsart tests.
Info
Has a bug. AWS github user does not have correct permissions to fully deploy slsart resources and tests.
Time Spent
2 hours researching serverless artillery and following the lab
1.5 hours debugging deployment errors and reading source code
1 hour writing new test and deploying