Skip to content

deploy web app to azure blob storage #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

farhadbahrehmandhenry
Copy link
Contributor

@farhadbahrehmandhenry farhadbahrehmandhenry commented Feb 6, 2021

how to use =>

  • after merging a PR this action gets triggered.
  • you can follow the action's step in Github/Actions/deploy-ui
  • if the action completes the job, you will have your latest changes deployed in this URL
  • please note you should wait until this PR gets merged first.

spent time =>

DATE ACTIVITY TIME
02/06 Investigation of Github Action/deployment 4hr
02/06 Implement GitHub Action For Deploy Web App 1 Hr
02/06 Testing GitHubAction 1hr
total 6hr

@farhadbahrehmandhenry farhadbahrehmandhenry self-assigned this Feb 7, 2021
@farhadbahrehmandhenry farhadbahrehmandhenry added task New task, feature or request team1 Issues for Practicum Team 1 labels Feb 7, 2021
@farhadbahrehmandhenry farhadbahrehmandhenry added this to the Sprint 03 milestone Feb 7, 2021
@farhadbahrehmandhenry farhadbahrehmandhenry changed the title Feature/issue133 team1 deploy web app deploy web app to azure blob storage Feb 12, 2021
@@ -10,7 +10,7 @@ let UserSingleTask = () => {
console.log(userId, taskId)

useEffect(() => {
fetch(`https://nsc-functionsapp-team1.azurewebsites.net/api/users/${userId}/tasks/${taskId}`)
fetch(`https://nsc-fun-dev-usw2-thursday.azurewebsites.net/api/users/${userId}/tasks/${taskId}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@@ -11,7 +11,7 @@ var UserTasks = () => {
useEffect(() => {
setUserTasks(['loading']);

fetch(`https://nsc-functionsapp-team1.azurewebsites.net/api/users/${userId}/tasks?`)
fetch(`https://nsc-fun-dev-usw2-thursday.azurewebsites.net/api/users/${userId}/tasks?`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@@ -10,9 +10,15 @@ var User = () => {
var {userId} = useParams();

useEffect(() => {
fetch(`https://nsc-functionsapp-team1.azurewebsites.net/api/users/${userId}?`)
fetch(`https://nsc-fun-dev-usw2-thursday.azurewebsites.net/api/users/${userId}?`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@@ -11,7 +11,7 @@ export default class Users extends Component {
};

async componentDidMount() {
const url = 'https://nsc-functionsapp-team1.azurewebsites.net/api/users';
const url = 'https://nsc-fun-dev-usw2-thursday.azurewebsites.net/api/users';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thanks for updating users as well.

@@ -1,6 +1,4 @@
.App {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clean up.

Copy link
Contributor

@jak-ashuraliev jak-ashuraliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good updates, cleanup, and deployment work like a charm, brother. You should apply to AWS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task New task, feature or request team1 Issues for Practicum Team 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Github action to deploy React app to the new storage account
3 participants