Skip to content

Change the GitHub action for serverless-artillery to test the new function /users/{user_id} and save the results in the right bucket #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 61 commits into
base: development
Choose a base branch
from

Conversation

Yergalem1
Copy link

@Yergalem1 Yergalem1 commented Feb 17, 2021

Steps to Reproduce

  1. Go to my fork yergu/ad440-winter2021-thursday-repo
  2. Change my branch to feature/GitHub-action-for-serverless-artillery
  3. Click on Actions
  4. Click on : Performance-Test serverless-artillery-action-users-id-api
  5. Click the recent workflow runs on he right pan
  6. Click on serverless artillery users Api Test and you will get the result

My script has an issue it looks like it has a conflict with another GitHub action
image
the S3 bucket is also not working yet

@yergu yergu requested a review from kevinles117 February 22, 2021 00:04
Copy link
Contributor

@kevinles117 kevinles117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the error you're getting, it looks like it has something to do with IAM user permissions? Did you use the correct secrets in the Azure keyvault? Make sure to go to the enabled key and click on it and scroll down for the actual key. That fixed my issue with secrets. But otherwise I think you have to talk to Dylan and Alex because I think they also had issues with IAM user permissions. Toddy should also be able to help

Copy link
Contributor

@Dylan-Riley Dylan-Riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks similar enough to what I ended up with. I'm not fully certain what the .js script does (if I'm being honest) but I need at least this file for my next work

@yergu
Copy link
Contributor

yergu commented Mar 5, 2021

I fixed the bug I created

@yergu yergu requested review from kevinles117 and toddysm March 6, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task New task, feature or request team2 Issues for Practicum Team 2
Projects
None yet
4 participants