-
Notifications
You must be signed in to change notification settings - Fork 27
Update Workflow orders #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dylan-Riley
wants to merge
12
commits into
North-Seattle-College:development
Choose a base branch
from
Dylan-Riley:I195_update_workflow_order
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Workflow orders #233
Dylan-Riley
wants to merge
12
commits into
North-Seattle-College:development
from
Dylan-Riley:I195_update_workflow_order
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Personal Fork 11/FEB/2021
Time tracking:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #195
So, testing this will be an issue before it gets merged into development... I was able to use
to make it so the final step of each workflow is to start the next workflow, but this only works if the workflows are in the default branch in Github. In the linked issue you can see testing I did in my private repo by putting two actions -- one triggers the next -- into the development branch. As far as I can tell from my research there is no way to daisy-chain them like that on an individual test branch.
I also ended up doing it this way since there's more online documentation and help for the repository_dispatch trigger (almost none for workflow_run and the documentation itself leaves something to be desired) and I found a nice guide that introduced it to me and I was able to get to work in small scale.
The only changes are renaming to match conventions, updating the on: trigger, updating the checkout so each subsequent workflow is checking out the same thing, and adding a final step to send the repository_dispatch and some needed info to the next workflow. None of the additional changes mentioned #195 (comment) nor #186 were addressed. Any existing issues still in the workflows as of 4/MAR/2021, 3:26 AM are still there and remain untouched due to testing constraints.