Skip to content

Update Workflow orders #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

Dylan-Riley
Copy link
Contributor

Resolves: #195

So, testing this will be an issue before it gets merged into development... I was able to use

on:
  repository_dispatch:
    types [$TRIGGER_NAME

to make it so the final step of each workflow is to start the next workflow, but this only works if the workflows are in the default branch in Github. In the linked issue you can see testing I did in my private repo by putting two actions -- one triggers the next -- into the development branch. As far as I can tell from my research there is no way to daisy-chain them like that on an individual test branch.

I also ended up doing it this way since there's more online documentation and help for the repository_dispatch trigger (almost none for workflow_run and the documentation itself leaves something to be desired) and I found a nice guide that introduced it to me and I was able to get to work in small scale.

The only changes are renaming to match conventions, updating the on: trigger, updating the checkout so each subsequent workflow is checking out the same thing, and adding a final step to send the repository_dispatch and some needed info to the next workflow. None of the additional changes mentioned #195 (comment) nor #186 were addressed. Any existing issues still in the workflows as of 4/MAR/2021, 3:26 AM are still there and remain untouched due to testing constraints.

@Dylan-Riley Dylan-Riley added task New task, feature or request team2 Issues for Practicum Team 2 labels Mar 4, 2021
@Dylan-Riley Dylan-Riley self-assigned this Mar 4, 2021
@Dylan-Riley
Copy link
Contributor Author

Time tracking:

  • 24/FEB to 4/MAR research on solutions to problem, weighing options -- 6 total hours (it's hard to google for this, kept getting unrelated marketplace results)
  • 4/MAR testing chosen solution with dummy workflows -- 0.5 hour
  • 4/MAR identifying, categorizing, ordering existing workflows -- 0.75 hour
  • 4/MAR editing identified workflow files -- 1 hour

@Dylan-Riley
Copy link
Contributor Author

Only ten working (presumably) workflows in /.github/workflows/ total, two of which aren't technically on my list.

Missing:

* artillery test for users/{user_id}

* serverless-artillery test for users/{user_id}/tasks/{task_id}

* All slsart UI tests

* Any UI testing aside from /users/

#195 (comment)

@Dylan-Riley Dylan-Riley requested a review from yergu March 4, 2021 23:08
@Dylan-Riley Dylan-Riley added this to the Sprint 04 milestone Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task New task, feature or request team2 Issues for Practicum Team 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Adjust Github Actions so they run in order
1 participant