Skip to content

Fix redis key #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix redis key #300

wants to merge 1 commit into from

Conversation

AllisonBC
Copy link
Contributor

Closes (#299)

Description: Redis key was incorrectly implemented for functions\HttpTriggerAPIUsersId_init_.py
Should be "users:{userId}" not "users:all"

To Test: (VS Code Azure Cache extension required.)

  1. Run debugger and do a GET request for userid 10.
  2. Check the cache to see that it's correctly implemented. Ex:
    image

Additional context:
Discovered in (#280)

@AllisonBC AllisonBC added the team3 Issues for Practicum Team 3 label Mar 23, 2021
@AllisonBC AllisonBC added this to the Sprint 06 milestone Mar 23, 2021
@AllisonBC AllisonBC self-assigned this Mar 23, 2021
@AllisonBC AllisonBC linked an issue Mar 23, 2021 that may be closed by this pull request
Redis key implementation for /users/{userid} #299
Open
@andluc21 andluc21 self-requested a review March 23, 2021 23:14
unicornsleuth
unicornsleuth approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@unicornsleuth unicornsleuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works! Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unicornsleuth unicornsleuth unicornsleuth approved these changes

@andluc21 andluc21 andluc21 approved these changes

@AlexSuth AlexSuth Awaiting requested review from AlexSuth

@jleeboyd jleeboyd Awaiting requested review from jleeboyd

@natni natni Awaiting requested review from natni

@zxkevinxz zxkevinxz Awaiting requested review from zxkevinxz

Assignees

@AllisonBC AllisonBC

Labels
team3 Issues for Practicum Team 3
Projects
None yet
Milestone
Sprint 06
Development

Successfully merging this pull request may close these issues.

Redis key implementation for /users/{userid}
3 participants
@AllisonBC @unicornsleuth @andluc21