Capture time to load users/ page 40 times using Puppeteer (with caching) #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllisonBC
requested review from
AlexSuth,
zxkevinxz,
natni,
jleeboyd and
unicornsleuth
| page.setCacheEnabled([true]); | ||
|
|
||
| for (let i = 0; i < testCount; ++i){ | ||
| await page.goto(url); |
There was a problem hiding this comment.
Some of your screenshots haven't loaded:
I found that changing the page.goto(url) to page.goto(url, waitUntil="networkidle2") fixed this - another option is "networkidle0" but I didn't find that to be necessary to get the loaded data.
| const browser = await puppeteer.launch(); | ||
|
|
||
| const page = await browser.newPage(); | ||
| page.setCacheEnabled([true]); |
There was a problem hiding this comment.
My understanding is that we're not using browser caching, we're using the Redis caching - so I think you should have this set to False and then test it while CACHE_TOGGLE is set to "True" in the Azure function app. But I'm not sure - I'll approve if you get the screenshots to wait until after the page fully loads. : )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #301
What it does:
Uses Puppeteer to load users/ page, timing the duration and taking a screenshot for each request.
To Test:
/test/uiin the integrated terminalnode load40-cache-on.jsPS C:\Users\allyb\AndroidStudioProjects\ad440-ds-practicum\ad440-winter2021-thursday-repo\test\ui> node load40-cache-on.js
results/ui-test-results/users-load40-cache-onTime Spent: