assistant/codecompanion-nvim: add mappings #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mappings for common commands in codecompanion-nvim
horriblename
requested changes
Apr 4, 2025
|
|
||
| self = import ./codecompanion-nvim.nix {inherit lib;}; |
There was a problem hiding this comment.
don't do this, this is leftover code that we haven't refactored yet. you can get the options definition from the "top-level" function args (see above)
| @@ -3,9 +3,21 @@ | |||
| lib, | |||
| ... | |||
There was a problem hiding this comment.
Suggested change
| ... | |
| options, | |
| ... |
then you can access the mappings option as options.vim.assistant.codecompanion-nvim.mappings
see run-nvim for a full example
|
@NotAShelf what's the current policy regarding default keymaps? are we still adding them or? |
I am still not very keen on adding more, but I also don't want to discourage anyone from contributing. Since we're going to add a toggle in the future, I think they are okay... for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out the
codecompanion-nvimplugin and noticed, there were no mappings available, so I mapped some common commands of the plugin.Maybe @ArmandoCIII could take a look too.
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.