Skip to content

fix(blink-cmp): Extended auto_show type #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

itpropro
Copy link
Contributor

@itpropro itpropro commented Jun 4, 2025

See https://cmp.saghen.dev/modes/cmdline.html#show-menu-automatically on how to add a function for more control of when the menu actually opens.

Copy link

github-actions bot commented Jun 4, 2025

🚀 Live preview deployed from cb4d834

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: fix/blink_auto_show

Reruns: 944

@itpropro
Copy link
Contributor Author

itpropro commented Jun 4, 2025

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that @NotAShelf ?

@horriblename
Copy link
Collaborator

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that

you can but it's not required. The point of setupOpts is so we don't have to add every plugin option out there

@NotAShelf
Copy link
Owner

Please ensure that the failing formatting checks (editorconfig and alejandra) pass before we can merge this.

github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
@itpropro
Copy link
Contributor Author

itpropro commented Jun 4, 2025

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that

you can but it's not required. The point of setupOpts is so we don't have to add every plugin option out there

The problem is that this is not consistent. SetupOpts in the blink case cannot be everything, as specific things under there are overwritten by custom options like the presets. So at least the options that are implemented should allow a high amount of customization or a way to overwrite them if need to be adjusted.

@horriblename
Copy link
Collaborator

The problem is that this is not consistent. SetupOpts in the blink case cannot be everything, as specific things under there are overwritten by custom options like the presets. So at least the options that are implemented should allow a high amount of customization or a way to overwrite them if need to be adjusted.

Sorry, I don't follow, can you give an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants