Skip to content

Begin DEVELOPMENT.md -> CONTRIBUTING.md #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

handrews
Copy link
Member

Create a new CONTRIBUTING.md and link it and DEVELOPMENT.md to each other. Move the recent sections over to CONTRIBUTING.md, and outline sections to organize the various topics that have issues tracking them.

Create a new CONTRIBUTING.md and link it and DEVELOPMENT.md to each other.
Move the recent sections over to CONTRIBUTING.md, and outline sections
to organize the various topics that have issues tracking them.

This section serves as a quick guide while we work on the full updated documentation.

If in doubt about a policy, please [ask on our Slack](https://communityinviter.com/apps/open-api/openapi) before opening a PR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have two links here, this one for new participants to sign up, and another one for existing participants that directly leads to the #spec channel?

CONTRIBUTING.md Outdated

4. If the suggested change has good support, you will be asked to create a formal proposal.
Use the [template in the proposals directory](https://github.com/OAI/OpenAPI-Specification/tree/main/proposals), copy it to a new file, and complete it.
Once you the document is ready, open a pull request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once you the document is ready, open a pull request.
Once you the document is ready, open a pull request to the `main` branch.

@@ -1,31 +1,14 @@
# CHANGES IN PROGRESS!!

Please see [CONTRIBUTING.md](CONTRIBUTING.md) for up-to-date guidelines. While we continue to [define and document our new processes](https://github.com/orgs/OAI/projects/5), we will keep this document as much of its contents are still relevant. However, if in doubt about a policy, please [ask on our Slack](https://communityinviter.com/apps/open-api/openapi).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also have two Slack links here, one for newcomers, one for returners

| 3.1.1 | `v3.1.1-dev` | `versions/3.1.1.md` | Soon to be published |
| 3.2.0 | `v3.2.0-dev` | `versions/3.2.0.md` | Planned for late 2024 |
| 4.0.0 | [OAI/sig-moonwalk](https://github.com/OAI/sig-moonwalk) | [discussions only](https://github.com/OAI/sig-moonwalk/discussions) | TBD, some proposals to be backported and published in 3.2.0 |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a section on "Markdown style". We have a set of conventions for how we write the spec documents -- we should capture these here and say that we enforce some of them with markdown lint (if we do). I think it would also be good to document our conventions for RFC and other links.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikekistler this is just to start an outline and populate it with material directly copied over - for additional content, we need to do additoinal PRs.

@handrews
Copy link
Member Author

handrews commented Aug 1, 2024

@ralfhandl @mikekistler I've included all the minor stuff. I don't know how to do the slack thing you want, so please handle that and other requested changes or additions as future PRs- this is just to get the skeleton and port over the sections that could be taken more-or-less verbatim.

mikekistler
mikekistler previously approved these changes Aug 2, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as the initial restructure. As @handrews says, there is more to do but I'm fine with leaving that work to future PRs.

@ralfhandl ralfhandl self-requested a review August 2, 2024 14:21
@ralfhandl ralfhandl requested a review from mikekistler August 2, 2024 14:21
@ralfhandl
Copy link
Contributor

ralfhandl commented Aug 2, 2024

@mikekistler Please reapprove & merge

Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renewing my approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants