Skip to content

[18.0][MIG] database_cleanup: Migration to 18.0 #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 91 commits into from
Oct 21, 2024

Conversation

nguyenminhchien
Copy link

@nguyenminhchien nguyenminhchien commented Oct 10, 2024

It found only 3 commits to port:

  • 1 ported successfully: 77ccd19
  • 2 were ignored, i added them to blacklist: c08c174

Big changes:

@pedrobaeza
Copy link
Member

/ocabot migration database_cleanup

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 10, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 10, 2024
31 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

/ocabot merge nobump

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3064-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 21, 2024
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3064-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sebalix
Copy link
Contributor

sebalix commented Oct 21, 2024

Hello @nguyenminhchien , can you rebase and run pre-commit again to fix the build?

diff --git a/database_cleanup/views/menu.xml b/database_cleanup/views/menu.xml
index a931997..9618986 100644
--- a/database_cleanup/views/menu.xml
+++ b/database_cleanup/views/menu.xml
@@ -63,5 +63,4 @@
         <field name="action" ref="cleanup_create_indexes_wizard_action" />
         <field name="parent_id" ref="menu_database_cleanup" />
     </record>
-
 </odoo>
Error: Process completed with exit code 1.

Stefan Rijnhart and others added 12 commits October 21, 2024 15:46
avoid ''NoneType' object has no attribute 'exists'' error when purging models
fix my change [email protected], wrong lines replaced...
    raw SQL query (but never read afterwards). Workaround for
    lp:1277899

[FIX] Preserve dangling workflow table which is in use

[RFR] Group models per table when detecting columns to purge
      to prevent problems with models sharing the same table

[ADD] Allow purging of dangling data entries

[FIX] Data purging now working

[IMP] Docstrings

[FIX] Label
[FIX] Catch attempt to unlink field from nonexisting model

[RFR] Flake8
[CHG] database_cleanup: move description to README.rst
[IMP] order wizard lines by name

[IMP] deal with modules whose models can't be loaded

[IMP] double quotes for docstring

[FIX] use exists query instead of huge in list

[IMP] hide unnecessary buttons in wizard II

[IMP] readability

[FIX] cope with purging nonexisting models
[ADD] test purging modules

[ADD] test purging tables
[FIX] database_cleanup reloads the registry

which has weird side effects during testing. Take care
database_cleanup's tests don't mess up the following tests
OCA-git-bot and others added 21 commits October 21, 2024 15:46
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-database_cleanup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/
Currently translated at 100.0% (81 of 81 strings)

Translation: server-tools-17.0/server-tools-17.0-database_cleanup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-database_cleanup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/
Currently translated at 100.0% (84 of 84 strings)

Translation: server-tools-17.0/server-tools-17.0-database_cleanup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/it/
Currently translated at 100.0% (84 of 84 strings)

Translation: server-tools-17.0/server-tools-17.0-database_cleanup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/zh_CN/
Currently translated at 100.0% (84 of 84 strings)

Translation: server-tools-17.0/server-tools-17.0-database_cleanup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup/es_AR/
@nguyenminhchien nguyenminhchien force-pushed the 18.0-mig-database_cleanup branch from a77dcc9 to bf4b81e Compare October 21, 2024 09:06
@nguyenminhchien
Copy link
Author

nguyenminhchien commented Oct 21, 2024

Hello @nguyenminhchien , can you rebase and run pre-commit again to fix the build?

diff --git a/database_cleanup/views/menu.xml b/database_cleanup/views/menu.xml
index a931997..9618986 100644
--- a/database_cleanup/views/menu.xml
+++ b/database_cleanup/views/menu.xml
@@ -63,5 +63,4 @@
         <field name="action" ref="cleanup_create_indexes_wizard_action" />
         <field name="parent_id" ref="menu_database_cleanup" />
     </record>
-
 </odoo>
Error: Process completed with exit code 1.

@sebalix Updated

@sebalix
Copy link
Contributor

sebalix commented Oct 21, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3064-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7c9d2a9 into OCA:18.0 Oct 21, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba932d5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.