Skip to content

[18.0][MIG] tracking_manager: Migration to 18.0 #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 15, 2025

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Mar 24, 2025

supersede: #3138

Kev-Roche and others added 20 commits March 24, 2025 21:27
- remove tracking_model (less model, less code, less issue)
- add automatic rule for default config (this avoid missing tracked field
after module installation)
For example on the product if you open the 'stock.putaway.rule'
you have activated the tracking on putaway_rule_ids
change on rule should be posted on the related product
- track m2m simplify using native mail_thread and process them like text
- simplify code for track one2many
- avoid useless code on model not impacted by the tracking
Instead of complexe tracking throught the context
just track change and process the message at the end
using the precommit feature (the message are posted
just before commiting)
Co-authored-by: Yoshi Tashiro (Quartile) <[email protected]>
@CRogos CRogos changed the title [MIG] tracking_manager: Migration to 18.0 [18.0][MIG] tracking_manager: Migration to 18.0 Mar 24, 2025
CRogos and others added 9 commits March 24, 2025 21:59
Currently translated at 100.0% (25 of 25 strings)

Translation: server-tools-17.0/server-tools-17.0-tracking_manager
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-tracking_manager/it/
Currently translated at 100.0% (25 of 25 strings)

Translation: server-tools-17.0/server-tools-17.0-tracking_manager
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-tracking_manager/zh_CN/
Previously the bank_ids field was used but account adds messages in partner when
a related bank account is created/modified/deleted, causing tests to fail.

The user_ids field of res.partner is now used to avoid the side effect in tests
and the fake model is removed.

TT50571
…subscribed to notes

Example use case:
- Enable custom tracking in project.project
- Activate the task_ids field as custom tracking
- Create a project and assign it to a user (different from ours) and make it a note follower
- Create a task in the project
- The project message of the task tracking task will not be sent to the note followers

TT50676
…child_ids of res.partner)

Example use case:
- Define the child_ids field of res.partner as tracking.
- Modify contact Brandon Freeman and leave parent_id empty (Azure Interior)
- No error should be displayed

TT51146
…ld that we do not have access

Example use case:
- Install hr_fleet
- Set the employee_ids field of hr.employee as a tracking field
- Modify the user to not have permissions in Fleet
- Modify the name of an employee

TT51160

[FIX] tracking_manager: Test compatibility

Related to OCA@b41e7ae

Do not set the child_ids field as tracking in the setup to avoid incorrect data in some cases

TT51160
@CRogos CRogos force-pushed the 18.0-mig-tracking_manager branch from d32831b to f1c3ce0 Compare March 24, 2025 21:59
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional & code review: LGTM

Copy link

@JessBrandl JessBrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Runboat and works as intended, Code LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos CRogos force-pushed the 18.0-mig-tracking_manager branch from f1c3ce0 to 39f6949 Compare April 15, 2025 17:21
@CRogos
Copy link
Contributor Author

CRogos commented Apr 15, 2025

@pedrobaeza could you review/merge?

@pedrobaeza
Copy link
Member

/ocabot migration tracking_manager
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 15, 2025
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3238-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 15, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_tracking_manager-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_tracking_manager-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Received "502: Bad Gateway"                                            
         Package upload appears to have failed. Retry 1 of 5.                   
Uploading odoo_addon_tracking_manager-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Received "502: Bad Gateway"                                            
         Package upload appears to have failed. Retry 2 of 5.                   
Uploading odoo_addon_tracking_manager-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Received "502: Bad Gateway"                                            
         Package upload appears to have failed. Retry 3 of 5.                   
Uploading odoo_addon_tracking_manager-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Received "502: Bad Gateway"                                            
         Package upload appears to have failed. Retry 4 of 5.                   
Uploading odoo_addon_tracking_manager-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Received "502: Bad Gateway"                                            
         Package upload appears to have failed. Retry 5 of 5.                   
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 502 Bad Gateway from https://upload.pypi.org/legacy/        
         Bad Gateway                                                            

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3238-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b341056 into OCA:18.0 Apr 15, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8c5ea46. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.