-
-
Notifications
You must be signed in to change notification settings - Fork 360
[18.0][MIG] sale_timesheet_line_exclude: Migration to 18.0 #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] sale_timesheet_line_exclude: Migration to 18.0 #769
Conversation
* [FIX] sale_timesheet_line_exclude: fix manifest * [FIX] sale_timesheet_task_exclude: fix manifest
Currently translated at 100.0% (5 of 5 strings) Translation: timesheet-15.0/timesheet-15.0-sale_timesheet_line_exclude Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-sale_timesheet_line_exclude/fr/
We don't copy the field by default, because it breaks the OE timesheet grid for users in the security group that hides the field. Functionally, it also makes sens to not copy this field, because it is better to consider the new line not excluded by default.
…clude flag While the test does not reveal this, without this change, clicking on the checkbox in the timesheet list view does not reset the so line.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-17.0/timesheet-17.0-sale_timesheet_line_exclude Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-sale_timesheet_line_exclude/
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-17.0/timesheet-17.0-sale_timesheet_line_exclude Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-sale_timesheet_line_exclude/it/
The failing tests are caused by odoo/odoo#205835. Once that PR is merged, i would rebase the mig branch so the tests here should pass as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGMT, Tested in runboat and works as intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code + Function LGTM
This PR has the |
I think we need to check this: #775 |
Since there hasn't been any progress on the original PR (#728), I opened this new one. I’ve reused the same changes as a basis for this PR.