fix #2626 in 2.0 #2678
Merged
fix #2626 in 2.0 #2678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerald-byrket
approved these changes
Mar 20, 2023
Oglopf
reviewed
Mar 21, 2023
apps/dashboard/app/models/files.rb
Outdated
Comment on lines
25
to
27
| valid_encoding = stats[:name].to_s.valid_encoding? | ||
| Rails.logger.warn("Not showing file '#{stats[:name]}' because it is not a UTF-8 filename.") unless valid_encoding | ||
| valid_encoding |
There was a problem hiding this comment.
This looks good, but for readability could we just do:
valid_encoding = stats[:name].to_s.valid_encoding?
unless valid_encoding
Rails.logger.warn("Not showing file '#{stats[:name]}' because it is not a UTF-8 filename.")
end
valid_encoding
|
I'm not sure what is causing the tests to fail on this PR. They don't seem related to the change, but am I missing something? |
I don't know, 2.0 tests just started failing at some point? #2632 fixes tests in 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2626 in 2.0. Can't directly use the commit from #2626, so it's a new commit.
┆Issue is synchronized with this Asana task by Unito