Feature/3999 zip template from project #4097
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… desired files and a manifest.yml
johrstrom
reviewed
Jan 27, 2025
euler-room
force-pushed
the
feature/3999-zip-template-from-project#show
branch
from
372b36d to
aa8f44d
Compare
johrstrom
reviewed
Apr 24, 2025
johrstrom
reviewed
Apr 24, 2025
johrstrom
reviewed
Apr 25, 2025
Comment on lines
+385
to
+389
| def create_template_manifest(file_names) | ||
| template_manifest = File.open("#{project_dataroot}/template_manifest.yml", "w") | ||
| template_manifest.write({ id: id, name: name, description: description, icon: icon, files: file_names }.to_yaml) | ||
| template_manifest.close | ||
| end |
There was a problem hiding this comment.
Why have a new file here? Why not just zip the actual manifest.yml?
There was a problem hiding this comment.
The manifest.yml does not include the list of files.
There was a problem hiding this comment.
🤦♂️ we haven't done #3987 yet...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: