beacon-api: add data column sidecars debug endpoint #15402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
debug-col-sc
branch
2 times, most recently
from
3dd0a68 to
f3e3415
Compare
terencechain
force-pushed
the
debug-col-sc
branch
from
f3e3415 to
a16f16b
Compare
|
cc @nalepae |
nalepae
reviewed
Jun 17, 2025
| @@ -0,0 +1,143 @@ | |||
| package column | |||
There was a problem hiding this comment.
What about using "data column" instead of "column"?
(Ideally, we should use blob sidecar and data column sidecar, since corresponding endpoints are for sidecars and not directly for blobs and data columns.)
| // parseIndices filters out invalid and duplicate blob indices | ||
| func parseIndices(url *url.URL, s primitives.Slot) ([]int, error) { | ||
| // ParseIndices filters out invalid and duplicate blob indices | ||
| func ParseIndices(url *url.URL, s primitives.Slot) ([]int, error) { |
There was a problem hiding this comment.
Is it working correctly with data columns?
This function has:
maxBlobsPerBlock := params.BeaconConfig().MaxBlobsPerBlock(s)
...
if !(0 <= ix && ix < maxBlobsPerBlock) {
invalidIndices = append(invalidIndices, raw)
continue
}What about data columns with index higher than MaxBlobsPerBlock?
(I guess reusing the function here is not something we should do.)
| @@ -41,6 +41,7 @@ func (e BlockIdParseError) Error() string { | |||
| type Blocker interface { | |||
| Block(ctx context.Context, id []byte) (interfaces.ReadOnlySignedBeaconBlock, error) | |||
| Blobs(ctx context.Context, id string, indices []int) ([]*blocks.VerifiedROBlob, *core.RpcError) | |||
| DataColumnSidecars(ctx context.Context, id string, indices []int) ([]blocks.VerifiedRODataColumn, *core.RpcError) | |||
There was a problem hiding this comment.
Here we have a discrepancy without Blobs and DataColumnSidecars.
Ideally, it should be BlobSidecars as well.
|
Changelog is missing. When testing it for: I got: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the addition proposed in: ethereum/beacon-APIs#537
Note to reviewer: I haven’t tested this on devnet1 yet, so please expect potential bugs. I’ll report back here once I get a chance to try it in production. Feel free to push directly to this branch if needed.