Make the multi-value slice permanent #15414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Jun 17, 2025
| @@ -562,17 +562,6 @@ func TestActiveValidatorIndices(t *testing.T) { | |||
| }, | |||
| want: []primitives.ValidatorIndex{0, 2, 3}, | |||
| },*/ | |||
| { | |||
| name: "impossible_zero_validators", // Regression test for issue #13051 | |||
There was a problem hiding this comment.
This is impossible to test. Validators are a multi-value slice and a non-nil value is created in InitializeFromProto even if you have a nil value in the proto state. I added a test in the mvslice package that shows initializing the mvslice with a nil value is also not a problem as it will work in the same way as initializing with an empty slice.
3 tasks
rkapka
commented
Jun 17, 2025
| @@ -9,16 +9,6 @@ import ( | |||
| "github.com/OffchainLabs/prysm/v6/testing/util" | |||
| ) | |||
|
|
|||
| func TestReportEpochMetrics_BadHeadState(t *testing.T) { | |||
There was a problem hiding this comment.
See https://github.com/OffchainLabs/prysm/pull/15414/files#r2151969948. SetValidators(nil) is not an issue because the mvslice can handle it.
rkapka
force-pushed
the
make-mvslice-permanent
branch
from
ae67a0c to
000cbde
Compare
rkapka
commented
Jun 17, 2025
| @@ -119,6 +119,7 @@ func TestFuzzEth1DataHasEnoughSupport_10000(t *testing.T) { | |||
| require.NoError(t, err) | |||
| _, err = Eth1DataHasEnoughSupport(s, eth1data) | |||
| _ = err | |||
| fuzz.FreeMemory(i) | |||
There was a problem hiding this comment.
I missed this one and the ones below in #15395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Graduation
What does this PR do? Why is it needed?
This makes our usage of multivalue slices permanent in the state and removes all the old state paths. This PR also deprecates the flag disabling the usage of the experimental state.
Other notes for review
Supersedes #15292 as I can't push to @nisdas 's repo
Acknowledgements