SSZ support for submitAttestationsV2 #15422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested changes
Jun 18, 2025
rkapka
reviewed
Jun 20, 2025
| } | ||
| i := 0 | ||
| for len(body) > 0 { | ||
| sszLen := 1 + int(body[0]) |
There was a problem hiding this comment.
Why isn't this sszLen := (ð.Attestation{}).SizeSSZ() like in the Electra case?
There was a problem hiding this comment.
because if I recall correctly, the ssz payload for an Attestation is 1 byte that specifies the length of the rest of the payload, and then the payload itself, and then the same for the next attestation
Ignore this.
There was a problem hiding this comment.
for clarification: the reason was that since AggregationBits in Attestation is variable length, the length of the Attestation object will be added as the first byte, per SSZ spec.
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
Jun 20, 2025
Inspector-Butters
added a commit
that referenced
this pull request
Jun 20, 2025
This reverts commit 9927cea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds SSZ support for the
submitPoolAttestationsV2beacon API.Which issues(s) does this PR fix?
Per this PR