Unblock apps to call dialog.url.submit in mobile #2788
Merged
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
jekloudaMSFT
approved these changes
Apr 29, 2025
noahdarveau-MSFT
approved these changes
May 14, 2025
MengyiGong
approved these changes
May 14, 2025
maglims
approved these changes
May 14, 2025
| @@ -83,11 +89,19 @@ export function botUrlOpenHelper( | |||
| } | |||
|
|
|||
| export function urlSubmitHelper(apiVersionTag: string, result?: string | object, appIds?: string | string[]): void { | |||
| ensureInitialized(runtime, FrameContexts.task); | |||
| // FrameContext content should not be here because dialog.submit can be called only from inside of a dialog (FrameContext task) | |||
There was a problem hiding this comment.
Do we need to create a TODO to track?
There was a problem hiding this comment.
Also, do we know if Teams mobile has a ETA to fix it properly on their end?
There was a problem hiding this comment.
@jekloudaMSFT do you know about the ETA? I have created a work item here:
https://office.visualstudio.com/MetaOS/_workitems/edit/10134868
There was a problem hiding this comment.
Teams mobile already has a work item for this, I'll see if I can link ours to theirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
Unblocked apps on Mobile to call
dialog.url.submitfrom dialog by allowing this API fromFrameContext.content.\nThere is a bug in Teams mobile that returnsframeContext.content in dialog instead offrameContext.task`. Once the bug is fixed, this change will be reverted.Main changes in the PR:
Validation
Validation performed:
Unit Tests added:
<Yes/No>
End-to-end tests added:
<Yes/No>
Additional Requirements
Change file added:
<Yes/No>
Related PRs:
Next/remaining steps:
Screenshots: