Update browser page address on navigation. Fixes #24 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies original function in that way that clicking on navigation menu will in effect update browser location allowing url sharing and bookmarking, etc. In modern browsers HTML5 History.pushState is used together with animation effect - while on older browser fall back is provided by just doing nothing - which in effect will simply update window.location.hash and scroll page in browser as per specification
nosami
added a commit
that referenced
this pull request
May 5, 2015
Update browser page address on navigation. Fixes #24
|
Thanks for this, and the other PRs! 👍 |
|
yes! missed your PR's @peterblazejewicz but they fixed most of my TODO's soo happy 👍 |
|
You're welcome folks! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accepted this PR enables bookmarking and url sharing, so people can navigate within content of the page.
This commit modifies original function in that way that
clicking on navigation menu will in effect update browser
location allowing url sharing and bookmarking, etc.
In modern browsers HTML5 History.pushState is used together
with animation effect - while on older browser fall back is
provided by just doing nothing - which in effect will simply
update window.location.hash and scroll page in browser as per
specification.
Thanks!