[Java] Default values for string-type query parameters are generated with two sets of quotes

[OmriHarary]

Description

In annotations on parameters for generated api methods, default values for request query parameters are surrounded in two sets of double quotes. Completely prevents compilation.

Example of problem code, generated using information below:

@ApiOperation(value = "", nickname = "fooGet", notes = "", tags={  })
    @ApiResponses(value = { 
        @ApiResponse(code = 200, message = "successful operation") })
    @RequestMapping(value = "/foo",
        method = RequestMethod.GET)
    default ResponseEntity<Void> fooGet(@ApiParam(value = "", defaultValue = ""foobar"") @Valid @RequestParam(value = "bar", required = false, defaultValue=""foobar"") String bar) {
        return new ResponseEntity<>(HttpStatus.NOT_IMPLEMENTED);

    }

Example partial result from running mvn package on generated project:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project openapi-spring: Compilation failure: Compilation failure:
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,80] ')' expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,86] <identifier> expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,88] ';' expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,159] ')' expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,165] <identifier> expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,167] ';' expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,179] = expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,181] illegal start of type
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[43,182] <identifier> expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[44,16] = expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[44,19] ';' expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[44,35] <identifier> expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[44,36] illegal start of type
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[44,37] '(' expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[44,47] illegal start of type
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[44,63] = expected
[ERROR] /path/to/src/main/java/org/openapitools/api/FooApi.java:[48,1] class, interface, or enum expected

openapi-generator version

latest master

OpenAPI declaration file content or url

openapi: 3.0.0
info:
  title: Issue example
  version: 1.0.0
paths:
  /foo:
    get:
      parameters:
        - name: bar
          in: query
          required: false
          schema:
            type: string
            default: foobar
      responses:
        default:
          description: successful operation

Command line used for generation

java -jar openapi-generator-cli.jar generate -g spring -i openapi.yaml

Steps to reproduce

Related issues/PRs

Suggest a fix/enhancement

[wing328]

@OmriHarary thanks for reporting the issue. I'll take a look tomorrow.

[OmriHarary]

@wing328 I found the source of the problem and will file a PR for a fix soon.

[OmriHarary]

Issue is not limited to the spring generator, also found in: jaxrs-cxf, jaxrs-spec, jaxrs-cxf-cdi, jaxrs-cxf-client, jaxrs-jersey, java-msf4j, jaxrs-resteasy, java-play-framework, and java-pkmst.

[wing328]

Thanks for offering help to fix it.

For the following:

        - name: bar
          in: query
          required: false
          schema:
            type: string
            default: foobar

Should it be using type directly instead?

        - name: bar
          in: query
          required: false
          type: string
          default: foobar

Ref: https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/test/resources/2_0/petstore.yaml#L203-L207

[OmriHarary]

The former is required for OAS3. ex: https://github.com/swagger-api/swagger-samples/blob/feature/oas3_petstore_sample/java/swagger-petstore/src/main/swagger/openapi.yaml#L234-L238

Issue occurs in either case anyways.

[wing328]

OK. I'll give it another try tomorrow and hopefully file a PR to fix all Java-related generators regarding this issue.