[BUG] Is it expected that generated python client code now depends on nulltype

[meadsteve]

Description

We've previously been running v5.0.0-beta2. Switching to the full release v5.0.0 results in the error ModuleNotFoundError: No module named 'nulltype'.

The fix was to add the nulltype package to my project's requirements but I'm not sure if this is expected and it doesn't seem ideal. Is this package really required or was it an accidentally inclusion?

openapi-generator version

v5.0.0

[spacether]

This is an accident
nulltype is still in the mustache template here: https://github.com/OpenAPITools/openapi-generator/blame/master/modules/openapi-generator/src/main/resources/python/model_templates/method_init_composed.mustache#L30

In my original composition pr here: https://github.com/OpenAPITools/openapi-generator/pull/5341/files#r379938730
nulltype.Null was used as the default value of required oneOf properties in a composed schema's init signature.
Since then, setting that nulltype.Null default value has been removed and those values are now passed in with kwargs.

So one can fix this by:

• deleting addNullDefaultToOneOfAnyOfReqProps from modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PythonClientExperimentalCodegen.java
• deleting the if nulltype.Null check should from https://github.com/OpenAPITools/openapi-generator/blame/master/modules/openapi-generator/src/main/resources/python/model_templates/method_init_composed.mustache#L30

[deeplook]

I wonder what the justification for using the nulltype package (for Python) really is? Looking at the code, it is more imported than used. And where it is used (in the petsore example) it's always with testing for nulltype.Null. Is that really worth doing and adding one more dependency which is not even available on conda-forge?

[spacether]

Hey there. The comment above describes why nulltype was added. As described in that comment it can now be removed.

[spacether]

This has been resolved by the above PR. nulltype is no longer included in the python generator.