Skip to content

[Java] fix nullable arrays when JsonNullable is used #10012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

borsch
Copy link
Member

@borsch borsch commented Jul 22, 2021

Fix for #9996

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@borsch borsch force-pushed the fix-nullable-array branch from 9bbafdd to 45e3457 Compare July 22, 2021 15:48
@borsch borsch force-pushed the fix-nullable-array branch from 45e3457 to f71851a Compare July 23, 2021 07:50
@borsch borsch closed this Jul 25, 2021
@borsch borsch reopened this Jul 25, 2021
@wing328 wing328 added this to the 5.2.1 milestone Jul 27, 2021
@wing328
Copy link
Member

wing328 commented Jul 27, 2021

Tested locally and the result is good.

@mariusmanastireanu
Copy link

mariusmanastireanu commented Sep 26, 2022

@borsch / @wing328 - can you please give a short look over #13385 and advice? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants