Skip to content

[JAVA] Fix clone method in RFC3339DateFormat template class #11363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fcanovas1986
Copy link
Contributor

@fcanovas1986 fcanovas1986 commented Jan 20, 2022

The implementation of clone method has been fixed to call super.clone() instead just return this.

The opened issue related is #11311

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@fcanovas1986 fcanovas1986 marked this pull request as ready for review January 20, 2022 14:31
@wing328
Copy link
Member

wing328 commented Jan 21, 2022

Tested with updated samples and the result is good. Next time please follow step 3 in the PR checklist to update the samples so that the CI can verify the result.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328 wing328 merged commit 5e1164c into OpenAPITools:master Jan 21, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 21, 2022
@fcanovas1986 fcanovas1986 deleted the fix/11311-RFC3339DateFormat_clone_method branch January 21, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants