FIX: remove special quotation marks from filename generation. #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@macjohnny The |
|
@macjohnny PR is now complete |
macjohnny
approved these changes
Oct 2, 2018
|
@wing328 replaced with |
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
…eflect new clean function so that the filename AND imports are added correctly
smasala
force-pushed
the
issue-1137-fix
branch
from
3f3bdc0 to
00b4eff
Compare
wing328
approved these changes
Oct 4, 2018
|
@smasala thanks again for the fix, which has been included in the v3.3.1 release: https://twitter.com/oas_generator/status/1052020299821080577 |
|
@wing328 Thanks! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…ITools#1157) * remove left|right point double angle quotation marks * move to DefaultCodeGen and update TypeScriptAngularClientCodegen to reflect new clean function so that the filename AND imports are added correctly * rename to a more accurate name :) * shippable fixes * shippable javadoc fix * replaced cleanModelFilename with sanitzeName * remove DefaultCodegen changes
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed with @tropan
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master(3.3.x),4.0.x. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09)
Description of the PR
Generics are given double left and right pointing quotation marks in the
JSONdeclaration file:MyModel«Set«AnotherType»»Although the API in (TypeScript) imports the models correctly:
The filename itself still has the special punctuation marks:
This pull request simply removes the special characters from the filename before creation by cleaning the filename string accordingly.
Original Issue:
#1137