Skip to content

Allow package version to be passed on CLI (Rust fix) #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Allow package version to be passed on CLI (Rust fix) #1286

merged 3 commits into from
Nov 5, 2018

Conversation

MF1-MS
Copy link
Contributor

@MF1-MS MF1-MS commented Oct 22, 2018

This MR allows package version to be specified in Rust in the generate argument list, with the argument -DpackageVersion=<package_version>. If this argument is present then the version in the resulting Cargo.toml file will be the passed value. If this argument is not present then the version in the OpenAPI definition file will be used, as per current behavior.

@MF1-MS MF1-MS changed the title Allow package version to be passed on CLI Allow package version to be passed on CLI (Rust fix) Oct 22, 2018
@MF1-MS
Copy link
Contributor Author

MF1-MS commented Oct 22, 2018

@frol (2017/07) @farcaller (2017/08) @bjgill (2017/12)

Copy link
Contributor

@bjgill bjgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd already reviewed this before submission. I'll leave it for a few days before merging to give others a chance to comment.

Also, I think I make an incorrect suggestion as to the branch that this should be on. Given that this is a back-compatible change, it should be against master. We're currently working off 4.0.x, but that's fine, because master is periodically merged into 4.0.x. I'll rebase accordingly to fix my mistake.

@bjgill bjgill changed the base branch from 4.0.x to master October 23, 2018 09:56
@bjgill bjgill merged commit 303b469 into OpenAPITools:master Nov 5, 2018
@bjgill bjgill deleted the packageVersion branch November 5, 2018 16:12
@wing328
Copy link
Member

wing328 commented Jan 2, 2019

@MF1-MS thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
This MR allows package version to be specified in Rust in the generate argument list, with the argument `-DpackageVersion=<package_version>`. If this argument is present then the version in the resulting Cargo.toml file will be the passed value. If this argument is not present then the version in the OpenAPI definition file will be used, as per current behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants