[Swift] Updates for Swift 4.2 #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with master
…o 4.2 for default and RxSwift variants
d-date
reviewed
Nov 15, 2018
samples/client/petstore/swift4/default/SwaggerClientTests/Podfile
Outdated
Show resolved
Hide resolved
added 5 commits
November 15, 2018 14:21
…rator into OpenAPITools-master # Conflicts: # samples/client/petstore/swift4/default/SwaggerClientTests/SwaggerClient.xcodeproj/project.pbxproj
|
I think this should be good now, can you do a re-review? |
|
@joeboyscout04 thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* [Swift] Update Alamofire version and update tests and Swift version to 4.2 for default and RxSwift variants * Update promiseKit for Swift 4.0 * Update project files. * Merge branch 'master' of https://github.com/OpenAPITools/openapi-generator into OpenAPITools-master # Conflicts: # samples/client/petstore/swift4/default/SwaggerClientTests/SwaggerClient.xcodeproj/project.pbxproj * Merge in latest master * Remove typo in bash file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.@jgavris @ehyche @Edubits @jaz-ah @d-date
Description of the PR
This PR updates various parts of the swift4 package including: