Upgrade haskell-servant generator to latest LTS #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade Servant to the latest version - Add Maybe for optional values - Add UUID, UTCTime and Day types - Fix the URL configuration so that it has one param with all data - Add Data and ToSchema instances to models - Switch to TLS http manager so it can connect to https urls - Add nicer API to call the endpoints - Add Nix support
|
cc @jonschoning, @algas to see if they've time to do a review on the change. |
|
definitely looks like an improvement over the old bitrotted code.
|
4 tasks
|
@jonschoning thanks for the review!
|
f-f
force-pushed
the
upgrade-haskell-servant
branch
from
dcf4e30 to
5729960
Compare
|
looks good to me |
|
@jonschoning thanks for reviewing the change. @f-f thanks for the enhancement, which has been merged into master. |
|
@f-f thanks again for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* [Haskell Servant] Upgrade to lts-12 - Upgrade Servant to the latest version - Add Maybe for optional values - Add UUID, UTCTime and Day types - Fix the URL configuration so that it has one param with all data - Add Data and ToSchema instances to models - Switch to TLS http manager so it can connect to https urls - Add nicer API to call the endpoints - Add Nix support * [Haskell Servant] Upgrade Petstore * [Haskell Servant] Delete old swagger-petstore samples * [Haskell Servant] Use generics for ToForm and FromForm instances * [Haskell Servant] Generate ToSchema instance only if it's safe to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Problem: the current
haskell-servantclient is based on a set of libraries (ltspackage set) from one year ago, based on the8.0.xrelease of GHC. It is typical for library writers in the Haskell community to maintain compatibility with the latest 3 major versions of the compiler. By this standard (since8.2,8.4and8.6are out) we are generating an outdated client. Moreover, theservantlibrary itself went through several breaking versions in the meanwhile, so the code generated by this generator is not really compatible with a project started today.This PR upgrades to the latest
lts(12.18 for GHC 8.4) andservantversion, and adds several new features:MaybesUUID,UTCTimeandDayare now represented with the correct typesurlToSchemainstances to generated types, so they can be re-exposed for free in the spec of the service using the clienttls-http-manager, so we can connect to https urlsstack.yamlNote: all of this is quite breaking, so I opened the PR against the
4.xbranch/cc @wing328