Skip to content

Fix NPE for Scala Gatling generator #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Fix NPE for Scala Gatling generator #1479

merged 1 commit into from
Nov 19, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 17, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix the following NPE:

[main] INFO  o.o.c.languages.AbstractScalaCodegen - Environment variable SCALA_POST_PROCESS_FILE not defined so the Scala code may not be properly formatted. To define it, try 'export SCALA_POST_PROCESS_FILE=/usr/local/bin/scalafmt' (Linux/Mac)
[main] INFO  o.o.c.languages.AbstractScalaCodegen - NOTE: To enable file post-processing, 'enablePostProcessFile' must be set to `true` (--enable-post-process-file for CLI).
Exception in thread "main" java.lang.NullPointerException
	at org.openapitools.codegen.languages.ScalaGatlingCodegen.preprocessOpenAPI(ScalaGatlingCodegen.java:242)
	at org.openapitools.codegen.DefaultGenerator.configureGeneratorProperties(DefaultGenerator.java:183)
	at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:854)
	at org.openapitools.codegen.cmd.Generate.run(Generate.java:349)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:62)

cc @clasnake (2017/07) @jimschubert (2017/09) @shijinkui (2018/01) @ramzimaalej (2018/03)

@jimschubert
Copy link
Member

@wing328 why would extensions be null here? Would it make more sense to ensure this is set and non-null in the type itself?

@wing328
Copy link
Member Author

wing328 commented Nov 17, 2018

@jimschubert totally agreed with you but the class for operation is in another package (io.swagger.core?), which is not something we can change in this project.

I also agree with you that it shouldn't be null in the first place and should be properly initialized with a Hashmap for the extension when the Operation object is constructed but unfortunately it's not how it's written at the moment.

@wing328 wing328 merged commit f58bd6d into master Nov 19, 2018
@wing328 wing328 deleted the fix_scala_gatling_npe branch November 19, 2018 03:06
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants