Skip to content

Update Elm for elm/http 2.0.0 #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented Nov 20, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Upgrade the generator to use the new elm/http package. This changes the way all APIs calls are called.

addPet : Pet -> Http.Request ()

becomes

addPet :
    { onSend : Result Http.Error () -> msg
    , body : Pet
    }
    -> Cmd msg

opening the way for additional flags to allow adding custom baseUrls, timeouts, trackers and headers (in follow-up PRs). This PR already adds support for query parameters and escapes all parameters safely by using elm/url.

cc @wing328

Fixes #1461.

@wing328
Copy link
Member

wing328 commented Nov 23, 2018

Looks good to me. I just restarted the Shippable job. Let's see how it goes.

@eriktim eriktim merged commit 5f1362d into OpenAPITools:4.0.x Nov 23, 2018
@eriktim eriktim deleted the elm-http-2.0 branch November 23, 2018 15:04
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants