Skip to content

Replace <tt> tags with <code> to make new javadoc work. #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

DenKoren
Copy link
Contributor

@DenKoren DenKoren commented Nov 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Modern version of JavaDoc refuses to generate documentation with usages messaging 'unknown tag' error. is qualified as obsolete. is the one of the tags recommended instead of

@wing328 wing328 changed the title Replace <tt> tags with <code> to make new jacadoc work. Replace <tt> tags with <code> to make new javadoc work. Dec 4, 2018
@wing328 wing328 added this to the 4.0.0 milestone Dec 4, 2018
@wing328 wing328 merged commit 8ee1553 into OpenAPITools:master Dec 4, 2018
@wing328
Copy link
Member

wing328 commented Jan 2, 2019

@DenKoren thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529.

Happy New Year and looking forward to more collaboration and contributions in 2019!

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…#1585)

Replace <tt> tags with <code> to make new javadoc work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants