Skip to content

Improve checkout script on NPMJS wrapper #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Improve checkout script on NPMJS wrapper #1595

merged 2 commits into from
Dec 4, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Dec 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update release checkout script to check the NPMJS wrapper version.

@wing328 wing328 added this to the 4.0.0 milestone Dec 2, 2018
@ackintosh
Copy link
Contributor

pom.xml.bash and pom.xml.bash were deleted in this PR. Are their not used now?

@wing328
Copy link
Member Author

wing328 commented Dec 3, 2018

@ackintosh very good question (and sorry I should have explained the change as part of the PR).

Those files are "merged" into pom.xml:

(these files are left over in 4.0.x branch likely due to syncing changes from master to 4.0.x branch that I did before)

@ackintosh
Copy link
Contributor

Thanks for the details. Understood. 💡

@wing328 wing328 merged commit cd61442 into master Dec 4, 2018
@wing328 wing328 deleted the improve-checkout branch December 4, 2018 03:16
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* improve checkout on npmjs wrapper

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants